Use color variables consistently #20677
Merged
+33
−33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replaces some raw colors with the appropriate color variables Example: #eee will be replaced by $gray-lighter (#eceeef)
|
Merged this manually given the conflicts. Only thing I took out was the |
Closed
|
Great! 🎉 Any idea how the many |
|
No clue honestly! 😆 |
|
Okay haha! I will take a look at it, maybe I find a suitable solution for this. 😃 |
sergiopantoja
added a commit
to sergiopantoja/bootstrap
that referenced
this pull request
Jan 10, 2017
This commit fixes twbs#21624 and solves the `#ddd` issue discussed in twbs#20677.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces some raw colors with the appropriate color variables where it makes sense.
Examples:
#eeewill be replaced by$gray-lighter(#eceeef)#333will be replaced by$gray-dark(#373a3c)The two colors
#fffand#dddare not replaced by a variable. In my opinion it would make sense to add a new variable for#dddbecause it's widely used but I wanted to ask first. Also the naming of the variable needs to be discussed.Reference: #14840