Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bg-* and text-* classes aren't controlled by @brand-* color variables #14840

Closed
vipseixas opened this issue Oct 21, 2014 · 4 comments
Closed
Labels

Comments

@vipseixas
Copy link

Only text-primary and bg-primary classes are affected by changes at the color section of the Customizer.

@cvrebert cvrebert added the css label Oct 21, 2014
@cvrebert
Copy link
Collaborator

Those colors are currently controlled by the @state-*-* variables instead of the @brand-* variables.

@cvrebert cvrebert changed the title Customizer do not change bg-* and text-* classes bg-* and text-* classes aren't controlled by @brand-* color variables Oct 21, 2014
@vipseixas
Copy link
Author

Sorry for the false bug report, but this is a little inconsistent since when you change the @brand-primary it changes the .text-primary and .bg-primary.
Maybe you should only change the text "Define colors for form feedback states and, by default, alerts." for "Define colors for form feedback states, contextual colors and, by default, alerts." just to clarify.

@cvrebert
Copy link
Collaborator

Oh yes, I quite agree it's inconsistent and could use justification; was just noting the actual cause since it wasn't truly customizer-related.

@mdo
Copy link
Member

mdo commented Oct 24, 2014

We'll aim to do better on this for v4. For now, it stays as a won't fix. Thanks though!

@mdo mdo closed this as completed Oct 24, 2014
@cvrebert cvrebert mentioned this issue Mar 6, 2015
@mdo mdo mentioned this issue Aug 19, 2015
kkirsche added a commit to kkirsche/bootstrap that referenced this issue Aug 20, 2015
X-Ref: twbs#14840 | twbs#17021

Not the _exact_ same colors but I think it's pretty close. Easy place to see colors via formula is: http://sassme.arc90.com
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants