Avoid using $.offset() on SVGs since it gives incorrect results in jQuery 3

[cvrebert]

Fixes #20280.
Refs jquery/jquery#3137
CC: @XhmikosR @hnrch02 @patrickhlauke

[twbs-savage]

Tests failed. Automated cross-browser testing via Sauce Labs and Travis CI shows that the JavaScript changes in this pull request are: BUSTED

Commit: 6b1e2bc
Build details: https://travis-ci.org/twbs-savage/bootstrap/builds/145303749
Docs preview: http://preview.twbsapps.com/c/${commitSha.sha}

(Please note that this is a fully automated comment.)

[cvrebert]

The Savage failure is Safari-specific, seemingly unrelated, and probably transient: https://saucelabs.com/jobs/c8bda0f8f4db468491e30a985319aabc
Will retry shortly.

[twbs-savage]

Tests passed. Automated cross-browser testing via Sauce Labs and Travis CI shows that the JavaScript changes in this pull request are: CONFIRMED

Commit: c4d1cdd
Build details: https://travis-ci.org/twbs-savage/bootstrap/builds/145305276
Docs preview: http://preview.twbsapps.com/c/${commitSha.sha}

(Please note that this is a fully automated comment.)

[hnrch02]

So for SVGs the position is now determined based on getBoundingClientRect alone, right? Does that mean tooltips are now be properly positioned when used in SVGs? I remember reading an issue about that problem some time ago.

[XhmikosR]

LGTM as far as I can tell.

[cvrebert]

So for SVGs the position is now determined based on getBoundingClientRect alone, right?

Correct.

Does that mean tooltips are now be properly positioned when used in SVGs?

That's already the case and should remain the case. We have a unit test specifically for SVG handling:

bootstrap/js/tests/unit/tooltip.js

Line 1042 in d3cbb8e

QUnit.test('should correctly position tooltips on SVG elements', function (assert) {

[cvrebert]

For extra assurance, I upgraded to jQuery 3 in an experimental commit (b9ac9e5) and the Sauce tests still passed on all browsers:
https://travis-ci.org/twbs/bootstrap/jobs/146142422

[hnrch02]

LGTM then.