Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

XXL grid size #19359

Closed
wants to merge 1 commit into from
Closed

XXL grid size #19359

wants to merge 1 commit into from

Conversation

baebb
Copy link

@baebb baebb commented Mar 1, 2016

XXL grid size for large screens

new size: 1520px

@cvrebert
Copy link
Collaborator

cvrebert commented Mar 1, 2016

Approximate duplicate of #14370.

@cvrebert
Copy link
Collaborator

cvrebert commented Mar 1, 2016

Why 1520px specifically?

@@ -123,7 +123,8 @@ $grid-breakpoints: (
sm: 544px,
md: 768px,
lg: 992px,
xl: 1200px
xl: 1200px,
xxl: 1560px
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I presume this is a typo and you meant 1520px here?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, oops

@cvrebert cvrebert mentioned this pull request Mar 1, 2016
@baebb
Copy link
Author

baebb commented Mar 1, 2016

i picked 1520 cause it's 1.3x1200 and 992 is 1.3x768.

is there a better number to choose before i fix the 1560px mistake?

@cvrebert
Copy link
Collaborator

cvrebert commented Mar 1, 2016

@mdo Has your opinion changed since #14370 (comment) ?

@baebb
Copy link
Author

baebb commented Mar 1, 2016

@mdo @cvrebert is it problematic to have >4 grid sizes?

I get that it's not hard to change the variables to your requirements via SASS and recompile, but me 3yrs ago [and other fresh devs] wouldn't have been able to do this. The point of BS was to make great web design accessible, right?

If there's a good reason to keep it 4 sizes then standard breakpoints should be updated at least.

@mdo
Copy link
Member

mdo commented Mar 1, 2016

Going to continue to pass on this. As this PR demonstrates, it's very easy to add a new tier to the grid (and get all the classes and mixins for free). We'll keep it as-is for now.

@mdo mdo closed this Mar 1, 2016
@cvrebert
Copy link
Collaborator

cvrebert commented Mar 2, 2016

is it problematic to have >4 grid sizes?

(Actually it'd be >5 since there are already 5 sizes.)
Not inherently, but adding sizes has trade-offs. Each additional grid size increases file size/"bloat" and increases cognitive load slightly. (And eventually, the names for the sizes start to get uglier/weirder.) So we have to balance these costs against how common and useful each new grid size would be. It's ultimately a judgment call.

then standard breakpoints should be updated at least.

If you have specific suggestions, feel free to open a new issue. 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants