-
-
Notifications
You must be signed in to change notification settings - Fork 79k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
XXL grid size #19359
XXL grid size #19359
Conversation
Approximate duplicate of #14370. |
Why 1520px specifically? |
@@ -123,7 +123,8 @@ $grid-breakpoints: ( | |||
sm: 544px, | |||
md: 768px, | |||
lg: 992px, | |||
xl: 1200px | |||
xl: 1200px, | |||
xxl: 1560px |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I presume this is a typo and you meant 1520px
here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah, oops
i picked 1520 cause it's 1.3x1200 and 992 is 1.3x768. is there a better number to choose before i fix the 1560px mistake? |
@mdo Has your opinion changed since #14370 (comment) ? |
@mdo @cvrebert is it problematic to have >4 grid sizes? I get that it's not hard to change the variables to your requirements via SASS and recompile, but me 3yrs ago [and other fresh devs] wouldn't have been able to do this. The point of BS was to make great web design accessible, right? If there's a good reason to keep it 4 sizes then standard breakpoints should be updated at least. |
Going to continue to pass on this. As this PR demonstrates, it's very easy to add a new tier to the grid (and get all the classes and mixins for free). We'll keep it as-is for now. |
(Actually it'd be >5 since there are already 5 sizes.)
If you have specific suggestions, feel free to open a new issue. 😄 |
XXL grid size for large screens
new size: 1520px