Reducing redundancy in output of the semantic grid columns system #13426
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I often have the following use case when generating semantic columns:
Meaning I need a class that fills a variable amount of columns, depending on breakpoints.
Before this patch, the code above would generate the following CSS:
I propose to use the grid system in the following way to reduce this redundancy:
or:
This means using the make-column mixin whenever we want to define a semantic column class. In my opinion this disadvantage beats redundant output though.
Your thoughts?