Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

including 2 make-xx-columns to a class creates double padding, floats etc #599

Closed
hugosaner opened this issue Apr 29, 2014 · 2 comments
Closed

Comments

@hugosaner
Copy link

First up I could be getting the methodology wrong, but if I do the following:

.class {
@include make-sm-column(12);
@include make-md-column(3);
}

in the css I get loads of repetition:

.class {
position: relative;
position: relative;
min-height: 1px;
min-height: 1px;
margin-bottom: 20px;
padding-top: 40px;
padding-right: 15px;
padding-right: 15px;
padding-left: 15px;
padding-left: 15px;
}

I guess firstly wanted to check that I am using the right convention and secondly could we add something like:

@mixin make-sm-column($columns, $gutter: $grid-gutter-width, $styles: "true") {
@if $styles == "true" {
position: relative;
min-height: 1px;
padding-left: ($gutter / 2);
padding-right: ($gutter / 2);
}

@media (min-width: $screen-sm-min) {
float: left;
width: percentage(($columns / $grid-columns));
}
}

Thanks

@cvrebert
Copy link
Collaborator

Probably the same cause as twbs/bootstrap#13426.

@cvrebert
Copy link
Collaborator

Per said issue, this will be fixed in Bootstrap v4, but not in v3 due to backward compatibility constraints.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants