Added support for AMD/CommonJS/Globals.

[pherrymason]

Pull request related to #12783

[VirtueMe]

Lots of linting exception.

[cvrebert]

@raulferras Per the contribution guidelines, please use 2-space indents instead of tabs.

[pherrymason]

Sure.

[jenssimon]

The "transition" dependencies won't work. The dependencies must not end with ".js".

So

(function (factory) {
  if (typeof define === 'function' && define.amd) {
    define(['jquery', './transition.js'], factory)
  } else if (typeof exports === 'object') {
    var jQuery = require('jquery')
    require('./transition.js')
    factory(jQuery)
  } else {
    factory(this.jQuery)
  }
}(function ($) {

should be replaced by

(function (factory) {
  if (typeof define === 'function' && define.amd) {
    define(['jquery', './transition'], factory)
  } else if (typeof exports === 'object') {
    var jQuery = require('jquery')
    require('./transition')
    factory(jQuery)
  } else {
    factory(this.jQuery)
  }
}(function ($) {

in

• alert.js
• carousel.js
• collapse.js
• modal.js
• tab.js
• tooltip.js

[pherrymason]

Ok, fixed.
It worked to me under CommonJS as webpack allows it.

[mokkabonna]

Hope this finally is going to make it in. Right now I can't even use jquery with AMD (with noconflict) because of:

bootstrap/Gruntfile.js

Line 35 in 73ad81d

jqueryCheck: 'if (typeof jQuery === \'undefined\') { throw new Error(\'Bootstrap\\\'s JavaScript requires jQuery\') }\n\n',

[pherrymason]

I don't know of AMD, but with CommonJS (webpack) I'm currently doing this:

var $ = require('jquery');
window.jQuery = $;
require('bootstrap');

This does it for me.

[zlatanvasovic]

@raulferras You should use jQuery = $, without the window..

[pherrymason]

That's true for bootstrap specifically, but other jQuery plugins require explicitly to overwrite window.jQuery, it all depends of the plugins/libs you're going to use.

[cvrebert]

Running cross-browser tests on Travis... https://travis-ci.org/twbs/bootstrap/builds/20557300

[cvrebert]

Browser tests pass!: https://travis-ci.org/twbs/bootstrap/jobs/20557303 😄

[cvrebert]

We should also add moduleType to bower.json after merging this. (Ref: bower/bower#934)

[cvrebert]

@twbs/team: So, aside from needing to test this manually/interactively in a few browsers beforehand, are there any objections to merging this PR?

[mdo]

I have zero objections as I know nothing about this. We'll need @fat to weigh in.

[fat]

yes. i object

[fat]

this stuff should be added at build time… dont think we should put it on the raw plugins

[fat]

i think ryan florence wrote a really complete version of this at one point… maybe we could use that to add at compile time?

[cvrebert]

Some possible options:

• https://github.com/alexlawrence/grunt-umd
• https://github.com/aearly/grunt-urequire

[pherrymason]

If this is added at build time, will we be allowed to build the different plugins indepently?

[cvrebert]

@raulferras It'd produce individual per-plugin "module-ized" JS files, if that's what you mean.

[pherrymason]

yes, great then.

[fat]

the more i think about this… the more I think that getting into the business of being other projects build systems seems like a bad idea.

I think as a guiding rule, it's generally safer to lean towards raw components, then trying to include all the hardware to connect to every 3rd party lib under the sun.

thoughts?

[zlatanvasovic]

Agree.

2014-03-23 2:51 GMT+01:00 Jacob [email protected]:

the more i think about this… the more I think that getting into the
business of being other projects build systems seems like a bad idea.

I think as a guiding rule, it's generally safer to lean towards raw
components, then trying to include all the hardware to connect to every 3rd
party lib under the sun.

thoughts?

—
Reply to this email directly or view it on GitHubhttps://github.com//pull/12909#issuecomment-38370499
.

Zlatan Vasović - ZDroid

[enricostano]

status? guide lines? any example out there? thanks!

[fat]

closing in favor of #13772