Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure that jQuery presence check added by Grunt doesn't break AMD or CommonJS #13811

Closed
cvrebert opened this issue Jun 13, 2014 · 2 comments
Closed

Ensure that jQuery presence check added by Grunt doesn't break AMD or CommonJS #13811

cvrebert opened this issue Jun 13, 2014 · 2 comments
Labels
build js
Milestone
v3.2.0

Comments

@cvrebert
Copy link
Collaborator

Follow-up to #13772.
We should have some test pages that exercise AMD/CommonJS usage of Bootstrap.
@cvrebert cvrebert added this to the v3.2.0 milestone Jun 13, 2014
@hnrch02
Copy link
Collaborator

hnrch02 commented Jun 13, 2014

I guess we can set up one example using RequireJS and one using Browserify. Where would we put those test pages though? In js/tests/umd?
Also, we need to change the presence check to:

if (typeof define  == 'undefined' &&
    typeof exports == 'undefined' &&
    typeof jQuery  == 'undefined') {
  throw new Error('Bootstrap\'s JavaScript requires jQuery')
}

cvrebert added a commit that referenced this issue Jun 17, 2014
@cvrebert
address #13811
3a4a87a
@cvrebert cvrebert mentioned this issue Jun 17, 2014
Merged
@hnrch02 hnrch02 mentioned this issue Jun 17, 2014
Closed
cvrebert added a commit that referenced this issue Jun 18, 2014
@cvrebert
address #13811
f347d7d
@cvrebert
Copy link
Collaborator Author

Checks fixed in #13842.
#13843 will cover the tests.

cvrebert added a commit that referenced this issue Jun 23, 2014
@cvrebert
Revert UMD (#13772 & friends) for now, due to #13812.
c2c19a4 
Will hopefully revert this reversion and land a fully-working version of UMD in v3.3.0.

Revert "some changes from #13801 - add strict mode back and =="
This reverts commit 2b302f6.

Revert "Fix regression of #10038 introduced by #13772"
This reverts commit e9d6756.

Revert "MD/CommonJS/Globals #12909"
This reverts commit 1c6fa90.

Revert "address #13811"
This reverts commit f347d7d.

Conflicts:
    js/carousel.js
    js/collapse.js
    js/dropdown.js
    js/modal.js
    js/tab.js
    js/tooltip.js
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
build js
Projects
None yet
Milestone
v3.2.0
Development

No branches or pull requests
2 participants
@cvrebert @hnrch02