Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warn about opening example HTML directly instead of viewing via HTTP #11014

Closed
wants to merge 1 commit into from

Conversation

cvrebert
Copy link
Collaborator

Viewing our example HTML files directly in the browser can break Glyphicons (see #10965) and breaks CDN links.
This commit displays an alert box when people do this to warn them about the brokenness.
/to @twbs/team for review

@mdo
Copy link
Member

mdo commented Oct 10, 2013

Gah, the whole reason we left the templates as whole HTML files is so folks could yank them without running a server. Sucks we have these problems, but they're not unique to our situation. Do you think this is better than just a warning in the docs somewhere?

@cvrebert
Copy link
Collaborator Author

Hmm. Now that I think about it, we can probably make the CDN links work by using HTTPS explicitly in their URLs. And only the Carousel example uses Glyphicons, so a note in that example itself would probably suffice.

That still leaves respond.js though...: http://stackoverflow.com/questions/18544310/respond-js-not-working-locally-support-for-media-queries-in-ie8

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants