Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not working with react-native #47

Closed
brysgo opened this issue Apr 23, 2015 · 2 comments
Closed

Not working with react-native #47

brysgo opened this issue Apr 23, 2015 · 2 comments

Comments

@brysgo
Copy link

brysgo commented Apr 23, 2015

I haven't figured out why yet, but requiring 'harmony-reflect' in react-native is giving me "SyntaxError: Unexpected end of script".

I am using harmony and the Proxy object is present.

@tvcutsem
Copy link
Owner

I think I see what's going on. react-native concatenates all the files, but is not robust against the last line of a file containing a comment. You can see the concatenated files by navigating to http://localhost:8081/index.ios.bundle (react-native put a closing }) after my comment)

Simply adding a newline at the end of your node_modules/harmony_reflect/reflect.js solves the issue.

I'll update my code and add the newline, even though this is really a concatenation issue of react-native.

Thanks for reporting!

@brysgo
Copy link
Author

brysgo commented Apr 26, 2015

thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants