Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Packager] naïve concatenation of JS files breaks things #1005

Closed
michaelficarra opened this issue Apr 24, 2015 · 2 comments
Closed

[Packager] naïve concatenation of JS files breaks things #1005

michaelficarra opened this issue Apr 24, 2015 · 2 comments
Labels
Resolution: Locked This issue was locked by the bot.

Comments

@michaelficarra
Copy link

See tvcutsem/harmony-reflect#47 (comment). A safe way to concatenate JS files would be to join on "\n;", but that is not robust against potential future additions to the language (such as allowing unclosed trailing multiline comments).

@amasad
Copy link
Contributor

amasad commented Apr 27, 2015

What's the ideal way to do it?

@michaelficarra
Copy link
Author

For scripts, there's no reliable way to combine two into the same file and preserve all semantics. For modules, you can just parse both programs and append the module items of the latter program to those of the former.

@brentvatne brentvatne changed the title naïve concatenation of JS files breaks things [Packager] naïve concatenation of JS files breaks things May 30, 2015
@amasad amasad closed this as completed in 477360b Jun 25, 2015
@facebook facebook locked as resolved and limited conversation to collaborators Jun 25, 2018
@react-native-bot react-native-bot added the Resolution: Locked This issue was locked by the bot. label Jul 22, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Resolution: Locked This issue was locked by the bot.
Projects
None yet
Development

No branches or pull requests

3 participants