Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for configuring connection timeout options for client endpoints #88

Merged
merged 1 commit into from
May 28, 2023

Conversation

psalin
Copy link
Collaborator

@psalin psalin commented Sep 14, 2022

Adds support for setting the connect_timeout and tcp_user_timeout options of chatterbox. The options can be set separately for each endpoint.

Requires tsloughter/chatterbox#16 for tcp_user_timeout support.

Adds support for setting the connect_timeout and tcp_user_timeout
options of chatterbox. The options can be set separately for each
endpoint.
@codecov
Copy link

codecov bot commented Sep 14, 2022

Codecov Report

Base: 39.02% // Head: 39.14% // Increases project coverage by +0.11% 🎉

Coverage data is based on head (a280971) compared to base (8cad52b).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #88      +/-   ##
==========================================
+ Coverage   39.02%   39.14%   +0.11%     
==========================================
  Files          28       28              
  Lines        2091     2095       +4     
==========================================
+ Hits          816      820       +4     
  Misses       1275     1275              
Impacted Files Coverage Δ
src/grpcbox_channel.erl 68.75% <100.00%> (ø)
src/grpcbox_subchannel.erl 61.11% <100.00%> (+4.86%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Owner

@tsloughter tsloughter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good for after I release a new chatterbox.

@tsloughter tsloughter merged commit cbb2961 into tsloughter:main May 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants