support connection options map in endpoint tuple #101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
psalin
approved these changes
May 31, 2023
|
The change looks good, its an easy change to take this into use. I agree that the current multi-tuple is not the clearest. |
|
@psalin ok great. I'm struggling to figure out how to fix the SSL setup for 24 and 25 (let alone 26). Once I figure that out I'll be able to merge this. |
|
On 25 I get "Handshake Failure\n unacceptable_rsa_key" in the ssl tests. |
tsloughter
force-pushed
the
connection-opts
branch
from
3f512ad to
6933659
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #101 +/- ##
==========================================
- Coverage 39.51% 39.47% -0.05%
==========================================
Files 28 28
Lines 2118 2118
==========================================
- Hits 837 836 -1
- Misses 1281 1282 +1
☔ View full report in Codecov by Sentry. |
tsloughter
force-pushed
the
connection-opts
branch
from
1bd761e to
1b21c35
Compare
tsloughter
force-pushed
the
connection-opts
branch
from
625d6be to
514fab8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@psalin this basically replaces #88 and will require changes for you in your usage if it goes in, so hoping you can review and give you thoughts.
I kinda want to rethink the whole 4 or 5-tuple thing... seems tedious instead of just a url and a map of options.