Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problems with samtools versions (1.10) #344

Closed
a-lapin opened this issue Dec 10, 2019 · 9 comments
Closed

Problems with samtools versions (1.10) #344

a-lapin opened this issue Dec 10, 2019 · 9 comments
Assignees
Labels
bug packaging Conda/Brew/etc

Comments

@a-lapin
Copy link

a-lapin commented Dec 10, 2019

Hi, I've recently upgraded samtools to version 1.10 via linuxbrew. Since this update snippy is broken, probably it presumes that v.1.10 < v.1.7


[11:40:06] Found vt - /home/linuxbrew/.linuxbrew/bin/vt
[11:40:06] Found snippy-vcf_to_tab - /home/linuxbrew/.linuxbrew/Cellar/snippy/4.4.5/bin/snippy-vcf_to_tab
[11:40:06] Found snippy-vcf_report - /home/linuxbrew/.linuxbrew/Cellar/snippy/4.4.5/bin/snippy-vcf_report
[11:40:06] Need samtools --version >= 1.7 but you have 1.10 - please upgrade it.
@a-lapin a-lapin changed the title Troubles with samtools versions (1.10) Problems with samtools versions (1.10) Dec 10, 2019
@tseemann
Copy link
Owner

Yes, it is a floating point comparison bug.

Please runbrew switch samtools 1.9 until I can fix it.

@tseemann tseemann self-assigned this Dec 10, 2019
@tseemann tseemann added bug packaging Conda/Brew/etc labels Dec 10, 2019
@andersgs
Copy link
Collaborator

Remember to run brew switch htslib 1.9 and brew switch bcftools 1.9_1 too.

@chienchi
Copy link

chienchi commented Dec 17, 2019

I tried to fix it by switching to a dotted-decimal $VERSION for comparison using "version" module. But not sure it is the correct way.

use version;

97 err("Need $cmd >= $min but you have $ver - please upgrade it.") if version->declare($ver) < version->declare($min);

@tseemann
Copy link
Owner

tseemann commented Dec 17, 2019

@chienchi that is a great core perl solution! i was thinking i would need SymVer.pm but your method is better. Might need to use version->parse() though - not sure.

@luciagrami
Copy link

Hello, I have the same issue but
$ samtools --version
throws:

samtools 1.9
Using htslib 1.9
Copyright (C) 2018 Genome Research Ltd.

And $brew switch samtools 1.9 gives an error:

Error: samtools not found in the Cellar.

@Abgarmar
Copy link

Same issue too after installing snippy via conda:

conda install -c conda-forge -c bioconda -c defaults snippy

Need samtools --version >= 1.7 but you have 1.10 - please upgrade it

samtools 1.10
Using htslib 1.10.1
Copyright (C) 2019 Genome Research Ltd.

@quocviet0908
Copy link

quocviet0908 commented Jan 10, 2020

Hi everyone,

I just got stuck in this problem as well and I think this solution can help.
After installing snippy v4.4.5, this version should come along with samtools and bcftools 1.10. You can downgrade samtools to 1.9 easily by running "conda install -c bioconda samtools=1.9" inside the snippy environment.

Cheer!

@a-lapin
Copy link
Author

a-lapin commented Feb 3, 2020

Hi!
I encountered a similar error with prokka and makeblastdb:

(base) argive@argive-PC:~/Desktop$ prokka --setupdb
[13:37:41] Appending to PATH: /home/linuxbrew/.linuxbrew/Cellar/prokka/1.14.0/bin
[13:37:41] Cleaning databases in /home/linuxbrew/.linuxbrew/Cellar/prokka/1.14.0/db
[13:37:41] Cleaning complete.
[13:37:41] Looking for 'makeblastdb' - found /home/linuxbrew/.linuxbrew/bin/makeblastdb
[13:37:41] Determined makeblastdb version is 2.10
[13:37:41] Prokka needs makeblastdb 2.8 or higher. Please upgrade and try again.

mvdbeek added a commit to mvdbeek/bioconda-recipes that referenced this issue Feb 5, 2020
BiocondaBot pushed a commit to bioconda/bioconda-recipes that referenced this issue Feb 5, 2020
Merge PR #20166, commits were: 
 * Pin max version if samtools and bcftools for snippy

Until tseemann/snippy#344 is resolved.
@tseemann
Copy link
Owner

This bug will be fixed in snippy 4.5.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug packaging Conda/Brew/etc
Projects
None yet
Development

No branches or pull requests

7 participants