-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
not working on node 10.5 #238
Comments
ahh, this is my problem! from Lines 357 to 380 in 5b165be
|
If anyone has any good ideas on how to solve this I'd be willing to put in a PR. |
I've opened #240 which fixes the issues with Basically the problem is that after restoring the mocked fs and then starting a new one writing to a stream created against the new mock fs will wind up calling back into |
Stat calls now work (thanks @tomhughes). I need to do more debugging to figure out how to handle the read after open. |
Any progress? |
This is due to MockFS not working in 10.5 and above. tschaub/mock-fs#238
@tschaub @tomhughes any news on solving the streams bug in Node v10.5+? This just become urgent for my current use case |
affects: @serenity-js/core The latest available version we can test on is 10.4 as mock-fs doesn't support node >= 10.5 yet (tschaub/mock-fs#238)
affects: @serenity-js/core The latest available version we can test on is 10.4 as mock-fs doesn't support node >= 10.5 yet (tschaub/mock-fs#238)
This should be addressed on the 4.8.0 release (thanks @huochunpeng, see #260). |
after fs module refactors and changes
The text was updated successfully, but these errors were encountered: