Update traviscs yaml for greenkeeper #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pierceray
reviewed
Sep 13, 2018
added 2 commits
September 13, 2018 12:58
pierceray
reviewed
Sep 18, 2018
package.json
Outdated
| @@ -33,7 +33,7 @@ | |||
| "@retailmenot/core-ui-gitignore": "^1.0.1", | |||
| "eslint": "^4.19.1", | |||
| "mock-fs": "^4.5.0", | |||
| "tap": "^11.1.5" | |||
| "tap": "^12.0.1" | |||
There was a problem hiding this comment.
You are going to need to update both tap and mock-fs to new versions to make this work.
There is also an outstanding issue with mock-fs that makes it not work past node 10.4.1. tschaub/mock-fs#238
pierceray
suggested changes
Sep 18, 2018
added 2 commits
September 24, 2018 09:46
pierceray
approved these changes
Sep 24, 2018
This was referenced Sep 25, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.