fix: ethereumjs-abi ENOLOCAL error

[drptbl]

changes:

• fixed ethereumjs-abi ENOLOCAL error (The latest version can't be installed with node v12.19.0 and npm v6.14.8 #650)
• reverted workaround (fix: bundle web3-provider-engine #652)

[drptbl]

Not sure why tests on CI has failed, doesn't seem related (macOS Node 10 & 12). I'm using macOS and Node 12 myself and they pass on my local machine, so I suspect flaky tests.

[davidmurdoch]

Thanks @drptbl! Because of the way npm treats shrinkwraps*, this PR won't actually fix the issue once the package is published.

So, what i'm going to do for today is create a release with your fix by manually editing the shrinkwrap before it published to npm. I hope to upstream a fix this week so ganache no longer relies on this git package.

Thanks for this PR, btw... it really is saving me some extra headache! I close this issue once I'm finished with this manual release.

• if we publish the npm-shrinkwrap.json as is, when a user runs npm install ganache-core npm will install all of ganache's devDependencies, despite them being marked as "dev": true in the npm-shrinkwrap.json. So what we do on pre-publish is npm prune --production and then run npm shrinkwrap to recreate the shrinkwrap with only production dependencies. This restores the buggy ethereumjs-abi@git+https://github.com/ethereumjs/ethereumjs-abi.git URL.

note: I'm using npm v7 to maintain the shrinkwrap file due to another npm v6 bug that creates entries in the npm-shrinkwrap.json that omits package some urls... urls that npm will attempt to use on npm install ganache-core, which causes npm to just crash.

[davidmurdoch]

Update: this npm v7 issue is making it tricky to publish: npm/cli#2045

[davidmurdoch]

I've published a beta and it looks like the fix works!

https://www.npmjs.com/package/ganache-core/v/2.13.1-beta.1

@drptbl, @alcuadrado do you mind installing this version out and letting me know if you have any issues?

[drptbl]

@davidmurdoch Indeed issue is fixed. Just tested. Thanks 👍.

[davidmurdoch]

Fixed in 2.13.1 https://www.npmjs.com/package/ganache-core/v/2.13.1