Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ethereumjs-abi ENOLOCAL error #817

Merged
merged 6 commits into from
Nov 2, 2020
Merged

Conversation

drptbl
Copy link
Contributor

@drptbl drptbl commented Oct 26, 2020

changes:

  • fixed ethereumjs-abi issue on npm install:
    f407fde
  • package-lock.json updated after npm install
  • switched from npm ci to npm install in CI (npm ci doesn't use cache and npm install is fixed now)

It was already fixed at ganache-core level with same fix (trufflesuite/ganache#653).
However until dependencies which rely on broken ganache-core are not updated to latest with a fix present (which for sure will take some time), this issue will occur. This PR will fix it in synthetix repository and all dependencies which rely on it.

@drptbl drptbl requested review from jjgonecrypto, eternauta1337 and zyzek and removed request for eternauta1337, jjgonecrypto and zyzek October 26, 2020 16:49
@codecov
Copy link

codecov bot commented Oct 26, 2020

Codecov Report

Merging #817 into develop will increase coverage by 0.05%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #817      +/-   ##
===========================================
+ Coverage    98.13%   98.18%   +0.05%     
===========================================
  Files           58       59       +1     
  Lines         3919     3922       +3     
  Branches       513      514       +1     
===========================================
+ Hits          3846     3851       +5     
+ Misses          73       71       -2     
Impacted Files Coverage Δ
contracts/MixinSystemSettings.sol 100.00% <ø> (ø)
contracts/SystemSettings.sol 100.00% <ø> (+2.17%) ⬆️
contracts/MintableSynthetix.sol 100.00% <100.00%> (ø)
contracts/SynthetixBridgeToBase.sol 100.00% <100.00%> (ø)
contracts/SynthetixBridgeToOptimism.sol 93.33% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1cf5ee9...7ff304c. Read the comment docs.

@jjgonecrypto jjgonecrypto merged commit 9a395ed into develop Nov 2, 2020
@jjgonecrypto jjgonecrypto deleted the fix-ethereumjsabi-ENOLOCAL branch November 2, 2020 22:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants