Skip to content
This repository has been archived by the owner on Sep 27, 2019. It is now read-only.

Build updates #26

Merged
merged 3 commits into from
Apr 4, 2018
Merged

Conversation

balasan
Copy link

@balasan balasan commented Mar 27, 2018

Ref ussue: #25

  • remove libraries from build
  • remove babel-polyfill
  • add babel-plugin-transform-runtime plugin to webpack build in place of babel-polyfill
  • add source maps to dev build
  • add dev start script that watches files for changes to package.json
  • remove dev folder from .gitignore

@balasan
Copy link
Author

balasan commented Mar 27, 2018

not sure if i should be making PR to 'develop' or 'master' - let me know if develop is better and I'll update

@balasan balasan changed the base branch from master to develop March 28, 2018 17:15
@tarrencev
Copy link

This is great. Unbundling of package dependencies is inline with best practices. Bundling should be left to the application depending on Drizzle.

I would however suggest leaving dist in the .gitignore. Or, at least, moving that change to a separate PR since the changes are independent.

@OnlyOneJMJQ OnlyOneJMJQ merged commit bc67994 into trufflesuite:develop Apr 4, 2018
@OnlyOneJMJQ
Copy link
Contributor

Agree with @tarrencev --great stuff! Thank you.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants