Skip to content
This repository has been archived by the owner on Sep 27, 2019. It is now read-only.

Added features, usable in Redux projects, works with Metamask #23

Closed
wants to merge 12 commits into from

Conversation

balasan
Copy link

@balasan balasan commented Mar 26, 2018

Apologies for a very big PR.

General build updates

  • Refactor webpack config to not include dependencies in the build
  • Remove dist from .gitignore for easy npm installs via github

Overview of New Features

  • Drizzle now watches and updates account balances
    • Breaking change: accounts state now contains ids and balances fields (see README)
  • Ability to use Metamask for accounts and sending/signing transactions (includes PR Add an option to ignore metamask #15)
  • Easier access to contract methods via store
    • Breaking change: contracts state is now stored in a state objects to avoid any naming collisions (see README)
  • Moved initialization of contract state from generateStore.js to DrizzleContracts.js
  • Added reducer and rootSaga to exports for use in existing redux projects

here is an example of using drizzle + Metamask in an existing redux app: https://github.com/relevant-community/bonding-curve-component/tree/redux/demo

closes: #10, #11 (and #20 sorta)

james1465 and others added 6 commits March 10, 2018 00:17
Drizzle isn't working well with metamask due to the lack of websockets report. Adding this option so that developers calling the library can tell Drizzle to ignore metamask and use it's fallback connection.
@balasan
Copy link
Author

balasan commented Mar 26, 2018

Ah just saw that the develop branch has diverged a bit @DiscRiskandBisque let me know if you're interested in incorporating any of these — especially getting it to work with existing redux projects and I can take a stab at the develop branch.

@tarrencev
Copy link

Would love the webpack changes to be merged asap

@balasan
Copy link
Author

balasan commented Mar 30, 2018

hey @tarrencev this PR is out of date with the master branch at this point, but I opened a separate one here #26 with just the webpack changes — hoping it will get merged soon!

@balasan balasan closed this Apr 4, 2018
@balasan
Copy link
Author

balasan commented Apr 4, 2018

closing this because its outdated - newer PRs include most of these updates

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants