Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NAS-130968 / 24.10-RC.1 / Do not attempt to start libvirt on shutdown (by Qubad786) #14403

Merged
merged 1 commit into from
Sep 3, 2024
Merged

NAS-130968 / 24.10-RC.1 / Do not attempt to start libvirt on shutdown (by Qubad786) #14403

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions src/middlewared/middlewared/plugins/vm/vms.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,11 +100,12 @@ def bootloader_ovmf_choices(self):
@private
def extend_context(self, rows, extra):
status = {}
shutting_down = self.middleware.call_sync('system.state') == 'SHUTTING_DOWN'
kvm_supported = self._is_kvm_supported()
if rows and kvm_supported:
if shutting_down is False and rows and kvm_supported:
self._safely_check_setup_connection(5)

libvirt_running = self._is_connection_alive()
libvirt_running = shutting_down is False and self._is_connection_alive()
for row in rows:
status[row['id']] = self.status_impl(row) if libvirt_running else get_default_status()

Expand Down
Loading