NAS-130968 / 24.10-RC.1 / Do not attempt to start libvirt on shutdown (by Qubad786) #14403
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(cherry picked from commit 94cbfe4)
yocalebo
approved these changes
Sep 3, 2024
|
This PR has been merged and conversations have been locked. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
During the shutdown process,
vm.queryattempts to establish a connection with libvirtd, which is already stopped by that time. This results in an attempt to start libvirtd, which fails because systemd does not permit services to start during shutdown.Solution:
Modify
vm.queryto prevent it from trying to establish a connection with libvirtd during the system's shutdown process, avoiding the issue entirely.Original PR: #14393
Jira URL: https://ixsystems.atlassian.net/browse/NAS-130968