NAS-130886 / 25.04 / stop calling websocket_local_ip #14385
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bugclerk
changed the title
bmeagherix
approved these changes
Aug 30, 2024
bmeagherix
reviewed
Aug 30, 2024
| if not host_ip: | ||
| try: | ||
| if app.origin.is_tcp_ip_family: | ||
| host_ip = app.origin.loc_addr |
There was a problem hiding this comment.
Oh, below you handled IPv6. Do we need to do so here too?
There was a problem hiding this comment.
@sonicaj do we need to put ipv6 address in brackets here for host_ip key in apps?
|
This PR has been merged and conversations have been locked. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the changes introduced here: #14372, we no longer need to pass the
appobject around and callwebsocket_local_ip.