-
Notifications
You must be signed in to change notification settings - Fork 492
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NAS-130867 / 25.04 / Simplify {TCPIP/UnixSock}Origin to ConnectionOrigin #14372
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bugclerk
changed the title
Simplify {TCPIP/UnixSock}Origin to ConnectionOrigin
NAS-130867 / 25.04 / Simplify {TCPIP/UnixSock}Origin to ConnectionOrigin
Aug 29, 2024
themylogin
reviewed
Aug 30, 2024
themylogin
reviewed
Aug 30, 2024
themylogin
reviewed
Aug 30, 2024
themylogin
approved these changes
Aug 30, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
This PR has been merged and conversations have been locked. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I broke
app.query
recently because we're passing@pass_app
objects around. After investigating this for 2 days, I realized we can simplify all of this and get rid of public methods likewebsocket_local_ip
andwebsocket_interface
and get the same information directly from theapp.origin
object.This removes all the Origin classes (and subclass) and creates a singular
ConnectionOrigin
object. I moved over the logic from the other classes to this one but added a few convenient properties (is_ha_connection
) so it's easier to use. This removes the necessity for importing these origin classes everywhere and doingisinstance
calls. I also get rid of theread_proc_net
andget_remote_addr
functions. The former is actually deprecated and the latter is unnecessarily expensive.CI runs for both HA and Single node passed with no obvious regressions: (here and here)