Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(bungee): error when MinecraftEncoder not present in netty pipeline #342

Merged
merged 1 commit into from
Nov 2, 2023
Merged

fix(bungee): error when MinecraftEncoder not present in netty pipeline #342

merged 1 commit into from
Nov 2, 2023

Conversation

diogotcorreia
Copy link
Member

Fixes #289

@diogotcorreia diogotcorreia added type:bug Something isn't working as expected module:bungeecord Related to BungeeCord labels Nov 2, 2023
@diogotcorreia diogotcorreia added this to the 3.9.1 milestone Nov 2, 2023
@diogotcorreia diogotcorreia self-assigned this Nov 2, 2023
@diogotcorreia diogotcorreia enabled auto-merge (squash) November 2, 2023 11:31
@diogotcorreia diogotcorreia merged commit 1b5328e into v3 Nov 2, 2023
1 check passed
@diogotcorreia diogotcorreia deleted the bug/minecraft-encoder-bungee-netty-pipeline branch November 2, 2023 11:31
diogotcorreia added a commit that referenced this pull request Nov 2, 2023
@diogotcorreia
refactor(bungee): get protocol version from pending connection
8cfe4f2 
Relates to #342
Relates to #289
@diogotcorreia diogotcorreia mentioned this pull request Nov 2, 2023
Merged
diogotcorreia added a commit that referenced this pull request Nov 2, 2023
@diogotcorreia
refactor(bungee): get protocol version from pending connection (#343)
7fb13e4 
Relates to #342
Relates to #289
diogotcorreia added a commit that referenced this pull request Nov 3, 2023
@diogotcorreia
refactor(bungee): get protocol version from pending connection (#343)
3f8f41e 
Relates to #342
Relates to #289

Port of 7fb13e4 to v4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@diogotcorreia diogotcorreia

Labels
module:bungeecord Related to BungeeCord type:bug Something isn't working as expected
Projects
Triton
Status: Done
Milestone
3.9.1
Development

Successfully merging this pull request may close these issues.

Error when injecting protocol on Bungee if connection is canceled
1 participant
@diogotcorreia