Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error when injecting protocol on Bungee if connection is canceled #289

Closed
diogotcorreia opened this issue Mar 18, 2023 · 1 comment · Fixed by #342
Closed

Error when injecting protocol on Bungee if connection is canceled #289

diogotcorreia opened this issue Mar 18, 2023 · 1 comment · Fixed by #342
Assignees
Labels
can't reproduce module:bungeecord Related to BungeeCord type:bug Something isn't working as expected
Milestone

Comments

@diogotcorreia
Copy link
Member

Describe the bug

If the client connection is cancelled (e.g. maintenance) the package injector fails.

How can the bug be reproduced?

No response

Expected behaviour

No response

Which Spigot fork are you using?

Vanilla Spigot (from BuildTools)

What's your server version?

irrelevant

Which proxy are you using?

BungeeCord

What's your proxy version?

irrelevant

What's the MC version of your client?

irrelevant

What's the Triton version you're using?

irrelevant

Additional Information

[13:41:36 ERROR] [Triton]: [PacketInjector] Failed to inject client connection for f6c4f5ae-267c-4a53-9e6c-ae00583fd325
[13:41:36 ERROR]: java.lang.NullPointerException: Cannot invoke "Object.getClass()" because "<parameter1>" is null
[13:41:36 ERROR]:       at com.rexcantor64.triton.utils.NMSUtils.getDeclaredField(NMSUtils.java:64)
[13:41:36 ERROR]:       at com.rexcantor64.triton.utils.NMSUtils.getDeclaredField(NMSUtils.java:60)
[13:41:36 ERROR]:       at com.rexcantor64.triton.BungeeMLP.injectPipeline(BungeeMLP.java:124)
[13:41:36 ERROR]:       at com.rexcantor64.triton.listeners.BungeeListener.lambda$onLogin$0(BungeeListener.java:49)
[13:41:36 ERROR]:       at net.md_5.bungee.scheduler.BungeeTask.run(BungeeTask.java:66)
[13:41:36 ERROR]:       at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1136)
[13:41:36 ERROR]:       at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:635)
[13:41:36 ERROR]:       at java.base/java.lang.Thread.run(Thread.java:833)
@diogotcorreia diogotcorreia added type:bug Something isn't working as expected triage Hasn't been manually reviewed labels Mar 18, 2023
@diogotcorreia diogotcorreia self-assigned this Mar 18, 2023
@diogotcorreia diogotcorreia added module:bungeecord Related to BungeeCord and removed triage Hasn't been manually reviewed labels Mar 18, 2023
@diogotcorreia diogotcorreia added this to the 3.8.4 milestone Mar 18, 2023
@diogotcorreia diogotcorreia modified the milestones: 3.8.4, 3.8.5 Apr 28, 2023
@diogotcorreia diogotcorreia modified the milestones: 3.8.5, 3.9.0, 3.9.1 Jun 18, 2023
@diogotcorreia
Copy link
Member Author

I was not able to reproduce the issue, but I'll handle this gracefully from now on.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
can't reproduce module:bungeecord Related to BungeeCord type:bug Something isn't working as expected
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

1 participant