Html render function #25
Conversation
src/suggestions.js
Outdated
| @@ -22,76 +22,74 @@ var Suggestions = function(el, data, options) { | |||
|
|
|||
| this.list.draw(); | |||
|
|
|||
| this.el.addEventListener('keyup', function(e) { | |||
| this.el.addEventListener('keyup', function (e) { | |||
There was a problem hiding this comment.
Can you remove the paren formatting throughout this pr?
| var indexOfQuery = indexString.lastIndexOf(this.query); | ||
| while (indexOfQuery > -1) { | ||
| var endIndexOfQuery = indexOfQuery + this.query.length; | ||
| boldString = boldString.slice(0, indexOfQuery) + '<strong>' + boldString.slice(indexOfQuery, endIndexOfQuery) + '</strong>' + boldString.slice(endIndexOfQuery); |
There was a problem hiding this comment.
Not sure I'm following this. if this render method allows a user to template a list item, would wrapping <strong> be desired or expected?
There was a problem hiding this comment.
If the user provides a custom render method, then that will be used instead. If the user does not provide a custom render function, then this default function will be used. The default function follows the existing functionality of wrapping the matching text in <strong> tags.
There was a problem hiding this comment.
oh dear me 🙈 I see now the existing functionality in the diff. 👍
src/suggestions.js
Outdated
| @@ -66,8 +69,8 @@ Suggestions.prototype.handleKeyDown = function(e) { | |||
| case 13: // ENTER | |||
| case 9: // TAB | |||
| if (!this.list.isEmpty()) { | |||
| if (this.list.isVisible()) { | |||
| e.preventDefault(); | |||
| if (this.list.isVisible()) { | |||
There was a problem hiding this comment.
nit: seeing some extra whitespace here and the line below
Exposes a render method that allows custom html to be displayed in the dropdown menu.