Custom html render #208
Merged
Custom html render #208
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| }, | ||
| getItemValue: function(item) { | ||
| return item.place_name | ||
| } |
There was a problem hiding this comment.
Is this just for your testing, or are you intending to default to showing an icon?
There was a problem hiding this comment.
Still just a WIP -- I'm planning on changing this back to match the existing functionality before merge.
It might be helpful to use this as an example here since it would demonstrate the custom render function and be a use case I suspect people are pretty familiar with.
katydecorah
approved these changes
Mar 20, 2019
There was a problem hiding this comment.
This looks great! I tested it out locally in #211 to create multiline results and it's super smooth 😎
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR approaches #153 by exposing two new constructor options
renderandgetItemValue.renderis a function that accepts a carmen geojson function and returns an html string to display in the dropdown menu. This function can be customized by settingoptions.renderso that any html can be rendered in the dropdown. This improves the customizability of the style/display of the results.getItemValueis a function that accepts a carmen geojson feature and returns a string to use in the search bar after a selection has been made. This method currently retains the old name, but perhaps we should name it something more intuitive in this context.Note: This requires the changes in tristen/suggestions#25 -- so we'll wait here until this upstream PR lands.
\cc @katydecorah @yuletide @kbauhaus