Switch Mongo, Kafka, Cassandra 'Latest' tests to BaseConnectorSmokeTest #7182
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
findepi
force-pushed
the
findepi/latest-smoke
branch
3 times, most recently
from
bd8fca4 to
037921a
Compare
findepi
force-pushed
the
findepi/latest-smoke
branch
from
bf7c8a1 to
4cae179
Compare
losipiuk
reviewed
Mar 8, 2021
| @@ -18,8 +18,8 @@ | |||
|
|
|||
| import static io.trino.plugin.mongodb.MongoQueryRunner.createMongoQueryRunner; | |||
|
|
|||
| public class TestMongo3DistributedQueriesLatest | |||
| extends BaseMongoDistributedQueries | |||
| public class TestMongo3LatestConnectorSmokeTest | |||
There was a problem hiding this comment.
latest are not latest any more. And honestly I do not get why these specific versions are tested :)
There was a problem hiding this comment.
Let's consider this out of scope here and see #5804
see also my reply in #7179 (comment)
losipiuk
approved these changes
Mar 8, 2021
|
CI #7209 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will reduce run time of these tests.