Update JDBC driver for MemSQL #7179
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
findepi
force-pushed
the
findepi/memsql-up
branch
from
f28a4aa to
4d6f1bf
Compare
This fixes compatibility issue with recent MemSQL versions.
The driver previously used would fail to authenticate, with following
being printed in MemSQL logs
ERROR: ProcessHandshakeResponsePacket() failed. Sending back 1045: Access denied for user 'root'@'172.17.0.1' (using password: YES)
findepi
force-pushed
the
findepi/memsql-up
branch
from
4d6f1bf to
58a4b71
Compare
|
CI #6723 |
losipiuk
reviewed
Mar 8, 2021
| @@ -31,6 +31,7 @@ | |||
| private static final String MEM_SQL_LICENSE = requireNonNull(System.getProperty("memsql.license"), "memsql.license is not set"); | |||
|
|
|||
| public static final String DEFAULT_TAG = "memsql/cluster-in-a-box:centos-7.1.13-11ddea2a3a-3.0.0-1.9.0"; | |||
| public static final String LATEST_TESTED_TAG = "memsql/cluster-in-a-box:centos-7.3.4-d596a2867a-3.2.4-1.10.1"; | |||
There was a problem hiding this comment.
would it make sense to add a test which checks if latest did not get stale?
There was a problem hiding this comment.
This is current pattern and see #5804 for more info.
We don't automatically support newer MemSQL version when one is released, so a test verifying our Latest is truly latest could start failing any time, and it could be hard to make it fixed, if there were any breaking changes.
We should read "Latest" as "Latest Tested" where "Tested" is omitted for brevity.
losipiuk
approved these changes
Mar 8, 2021
This was referenced Mar 8, 2021
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes compatibility issue with recent MemSQL versions.
The driver previously used would fail to authenticate, with following
being printed in MemSQL logs