Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the Accumulo connector #23791

Merged
merged 2 commits into from
Oct 29, 2024
Merged

Conversation

mosabua
Copy link
Member

@mosabua mosabua commented Oct 15, 2024

Description

The community expressed interest in removing this connector. More details in the linked issue.

Additional context and related issues

Fixes #23792
Fixes #20965
Fixes #16437
Fixes #5842
Fixes #3558

Release notes

(x) Release notes are required, with the following suggested text:

## Accumulo connector

* Remove the Accumulo connector. ({issue}`23792`)

@wendigo
Copy link
Contributor

wendigo commented Oct 15, 2024

giphy

Copy link
Member

@ebyhr ebyhr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Though I am not against this removal, this connector is unfortunately used in Trino: The Definitive Guide.

.github/workflows/ci.yml Show resolved Hide resolved
@mosabua mosabua closed this Oct 15, 2024
@mosabua mosabua reopened this Oct 15, 2024
@mosabua
Copy link
Member Author

mosabua commented Oct 15, 2024

Though I am not against this removal, this connector is unfortunately used in Trino: The Definitive Guide.

Believe me .. I know about this ;-) .. but honestly I dont think that should stop us. Let me add that info to the issue

@wendigo
Copy link
Contributor

wendigo commented Oct 16, 2024

@ebyhr good point but we should just amend the book

@wendigo
Copy link
Contributor

wendigo commented Oct 19, 2024

Can we merge it @martint @electrum @dain ?

@mosabua
Copy link
Member Author

mosabua commented Oct 19, 2024

I think we should mention it in the contributor and maintainer calls this week and I have to do some more research .. at this stage for the 463 release might be realistic

@mosabua mosabua marked this pull request as ready for review October 25, 2024 19:30
@mosabua
Copy link
Member Author

mosabua commented Oct 25, 2024

Lets wait over the weekend and into next week for more feedback but I think we can probably merge this for 464.

@mosabua mosabua force-pushed the no-more-acc branch 2 times, most recently from 933d743 to a55df54 Compare October 28, 2024 21:04
The connector seems unused from all interaction on the community
and following an investigation with users, vendors, and customers.

More details about the removal are captured in
trinodb#23792
Specifically change to an example from the Iceberg connector, since
current example with the Accumulo connector is no longer valid when
that connector is removed.
@mosabua mosabua merged commit e3934ea into trinodb:master Oct 29, 2024
39 of 95 checks passed
@mosabua mosabua deleted the no-more-acc branch October 29, 2024 16:18
@mosabua
Copy link
Member Author

mosabua commented Oct 29, 2024

Failures are false alarms ..

@github-actions github-actions bot added this to the 464 milestone Oct 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment