Do not shade opentelemetry in JDBC driver #23458
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OpenTelemetry should be provided by the execution environment that wants to instrument Trino JDBC driver rather than by the driver itself.
losipiuk
reviewed
Sep 17, 2024
wendigo
force-pushed
the
serafin/do-not-shade-opentelemetry
branch
from
7b56488 to
0dfa85f
Compare
losipiuk
reviewed
Sep 17, 2024
client/trino-jdbc/src/main/java/io/trino/jdbc/NonRegisteringTrinoDriver.java
Outdated
Show resolved
Hide resolved
losipiuk
approved these changes
Sep 17, 2024
nineinchnick
approved these changes
Sep 17, 2024
client/trino-jdbc/src/main/java/io/trino/jdbc/NonRegisteringTrinoDriver.java
Outdated
Show resolved
Hide resolved
nineinchnick
approved these changes
Sep 17, 2024
|
This can be used to install tracing driver using: |
losipiuk
approved these changes
Sep 17, 2024
|
@electrum FYI |
mosabua
previously requested changes
Sep 17, 2024
wendigo
dismissed
mosabua’s stale review
JDBC works as before - OTEL dependencies not needed
mosabua
approved these changes
Sep 17, 2024
|
@electrum do you want to take a look? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #21104 #21689 #18348
Description
Additional context and related issues
Also related to #23452
Release notes
( ) This is not user-visible or is docs only, and no release notes are required.
(x) Release notes are required. Please propose a release note for me.
( ) Release notes are required, with the following suggested text: