Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert non-shaded jdbc driver #23452

Merged
merged 2 commits into from
Sep 16, 2024
Merged

Revert non-shaded jdbc driver #23452

merged 2 commits into from
Sep 16, 2024

Conversation

mosabua
Copy link
Member

@mosabua mosabua commented Sep 16, 2024

Description

The core issue the original PR attempted to address was that OpenTelemetry could not access the shaded classes correctly. However this upstream limitation is gone. OpenTelemetry is now capable of working with the shaded classes. The convention for jdbc drivers to be self-contained and not rely on additional binaries. Providing non-shaded jars encourages wrong usage of the jdbc driver and increases the complexity and surface of potential misuse, and therefore our support needs. As a result we decided to remove this again since the original need no longer exists. @electrum and @wendigo will continue to improve this and work towards pulling the client libraries into the jdbc driver and then also use those from the CLI and therefore further reduce the API exposure.

Reverting as suggested @electrum and agreed with @wendigo
Also see #23446

fyi @gaeljw

Release notes

( ) This is not user-visible or is docs only, and no release notes are required.
(x) Release notes are required. Please propose a release note for me.
( ) Release notes are required, with the following suggested text:

## JDBC

* Remove publishing a JDBC driver JAR without bundled, third-party
  dependencies. ({issue}`23452`)

@cla-bot cla-bot bot added the cla-signed label Sep 16, 2024
@github-actions github-actions bot added jdbc Relates to Trino JDBC driver docs labels Sep 16, 2024
@mosabua
Copy link
Member Author

mosabua commented Sep 16, 2024

Somehow jdbc compatibility tests failed. I pushed again since it seems to have been a build time out.

@mosabua
Copy link
Member Author

mosabua commented Sep 16, 2024

JDBC now passes. Other failures were unrelated. Merging

@mosabua mosabua merged commit d356f2c into trinodb:master Sep 16, 2024
86 of 98 checks passed
@mosabua mosabua deleted the rev branch September 16, 2024 22:43
@github-actions github-actions bot added this to the 458 milestone Sep 16, 2024
@ebyhr
Copy link
Member

ebyhr commented Sep 16, 2024

@mosabua Could you explain the reason in the PR description?

@mosabua
Copy link
Member Author

mosabua commented Sep 16, 2024

@mosabua Could you explain the reason in the PR description?

Done .. i hope that makes enough sense.

@mosabua
Copy link
Member Author

mosabua commented Sep 17, 2024

Follow up PR #23458

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed docs jdbc Relates to Trino JDBC driver
Development

Successfully merging this pull request may close these issues.

3 participants