Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add query-partition-filter-required-schemas config property to Iceberg connector #22540

Conversation

okayhooni
Copy link
Contributor

@okayhooni okayhooni commented Jun 28, 2024

Description

  • add query-partition-filter-required-schemas config to iceberg connector, same as hive connector

Additional context and related issues

Release notes

# Iceberg
* Add support for setting partition required schemas via `query-partition-filter-required-schemas` config property

@cla-bot cla-bot bot added the cla-signed label Jun 28, 2024
@github-actions github-actions bot added docs iceberg Iceberg connector labels Jun 28, 2024
@ebyhr ebyhr changed the title add query-partition-filter-required-schemas config to iceberg connector, same as hive connector Add query-partition-filter-required-schemas config property to Iceberg connector Jul 2, 2024
@okayhooni okayhooni force-pushed the iceberg/query-partition-filter-required-schemas branch 2 times, most recently from c88d50b to 57c61f4 Compare July 8, 2024 05:50
@okayhooni okayhooni requested a review from ebyhr July 8, 2024 05:57
@okayhooni okayhooni force-pushed the iceberg/query-partition-filter-required-schemas branch 4 times, most recently from 88a9944 to ef2c3e7 Compare July 8, 2024 09:22
@okayhooni
Copy link
Contributor Author

okayhooni commented Jul 9, 2024

@ebyhr , I think.. current ci test error is not relevant to this MR.

Error:  Tests run: 459, Failures: 0, Errors: 1, Skipped: 5, Time elapsed: 647.8 s <<< FAILURE! -- in io.trino.plugin.iceberg.TestIcebergMinioOrcConnectorTest
Error:  io.trino.plugin.iceberg.TestIcebergMinioOrcConnectorTest.testOptimizeTimePartitionedTable -- Time elapsed: 248.9 s <<< ERROR!
io.trino.testing.QueryFailedException: Failed to open file: s3://test-iceberg-orc-mtxhbkpynu/iceberg_data/tpch/test_optimize_time_partitioned_timestamp6withtimezone_days-
       ...
	Suppressed: java.lang.Exception: SQL: ALTER TABLE test_optimize_time_partitioned_timestamp6withtimezone_days EXECUTE optimize WHERE p >= DATE '2022-04-01'
		at io.trino.testing.DistributedQueryRunner.executeInternal(DistributedQueryRunner.java:565)
		... 13 more

@okayhooni
Copy link
Contributor Author

@ebyhr Could you please review this PR again..?

@okayhooni okayhooni force-pushed the iceberg/query-partition-filter-required-schemas branch from ef2c3e7 to 76f83e9 Compare July 24, 2024 08:04
@okayhooni okayhooni force-pushed the iceberg/query-partition-filter-required-schemas branch from 76f83e9 to c22cefa Compare July 24, 2024 08:28
@okayhooni okayhooni requested a review from ebyhr July 24, 2024 09:01
@okayhooni
Copy link
Contributor Author

@ebyhr , Thank you for the detailed review.
I have applied all your review comments to the code.
The current CI error appears to be unrelated to this commit and seems to be a random failure.

@ebyhr ebyhr merged commit 859a9e6 into trinodb:master Jul 25, 2024
46 checks passed
@github-actions github-actions bot added this to the 453 milestone Jul 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

3 participants