-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add query-partition-filter-required-schemas
config property to Iceberg connector
#22540
Merged
ebyhr
merged 1 commit into
trinodb:master
from
okayhooni:iceberg/query-partition-filter-required-schemas
Jul 25, 2024
Merged
Add query-partition-filter-required-schemas
config property to Iceberg connector
#22540
ebyhr
merged 1 commit into
trinodb:master
from
okayhooni:iceberg/query-partition-filter-required-schemas
Jul 25, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raunaqmorarka
approved these changes
Jul 1, 2024
ebyhr
reviewed
Jul 2, 2024
plugin/trino-iceberg/src/main/java/io/trino/plugin/iceberg/IcebergConfig.java
Outdated
Show resolved
Hide resolved
plugin/trino-iceberg/src/main/java/io/trino/plugin/iceberg/IcebergSessionProperties.java
Outdated
Show resolved
Hide resolved
plugin/trino-iceberg/src/test/java/io/trino/plugin/iceberg/BaseIcebergConnectorTest.java
Outdated
Show resolved
Hide resolved
plugin/trino-iceberg/src/test/java/io/trino/plugin/iceberg/BaseIcebergConnectorTest.java
Outdated
Show resolved
Hide resolved
plugin/trino-iceberg/src/test/java/io/trino/plugin/iceberg/BaseIcebergConnectorTest.java
Outdated
Show resolved
Hide resolved
ebyhr
changed the title
add query-partition-filter-required-schemas config to iceberg connector, same as hive connector
Add Jul 2, 2024
query-partition-filter-required-schemas
config property to Iceberg connector
okayhooni
force-pushed
the
iceberg/query-partition-filter-required-schemas
branch
2 times, most recently
from
July 8, 2024 05:50
c88d50b
to
57c61f4
Compare
okayhooni
force-pushed
the
iceberg/query-partition-filter-required-schemas
branch
4 times, most recently
from
July 8, 2024 09:22
88a9944
to
ef2c3e7
Compare
@ebyhr , I think.. current ci test error is not relevant to this MR.
|
@ebyhr Could you please review this PR again..? |
ebyhr
reviewed
Jul 23, 2024
plugin/trino-iceberg/src/test/java/io/trino/plugin/iceberg/BaseIcebergConnectorTest.java
Outdated
Show resolved
Hide resolved
plugin/trino-iceberg/src/test/java/io/trino/plugin/iceberg/BaseIcebergConnectorTest.java
Outdated
Show resolved
Hide resolved
plugin/trino-iceberg/src/test/java/io/trino/plugin/iceberg/BaseIcebergConnectorTest.java
Outdated
Show resolved
Hide resolved
plugin/trino-iceberg/src/test/java/io/trino/plugin/iceberg/BaseIcebergConnectorTest.java
Outdated
Show resolved
Hide resolved
plugin/trino-iceberg/src/test/java/io/trino/plugin/iceberg/BaseIcebergConnectorTest.java
Outdated
Show resolved
Hide resolved
plugin/trino-iceberg/src/main/java/io/trino/plugin/iceberg/IcebergConfig.java
Outdated
Show resolved
Hide resolved
okayhooni
force-pushed
the
iceberg/query-partition-filter-required-schemas
branch
from
July 24, 2024 08:04
ef2c3e7
to
76f83e9
Compare
okayhooni
force-pushed
the
iceberg/query-partition-filter-required-schemas
branch
from
July 24, 2024 08:28
76f83e9
to
c22cefa
Compare
@ebyhr , Thank you for the detailed review. |
ebyhr
approved these changes
Jul 25, 2024
This was referenced Jul 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
query-partition-filter-required-schemas
config to iceberg connector, same as hive connectorAdditional context and related issues
query-partition-filter-required-schemas=our_raw_data_schema
to prevent unintended heavy queries from being submitted to those Bronze tier tables on Iceberg catalogs, same as Hive catalogs.query_partition_filter_required_schemas
config property in Hive connector #22522Release notes