Fix bug on query_partition_filter_required_schemas config property in Hive connector
#22522
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ebyhr
reviewed
Jun 28, 2024
...ct-tests/src/main/java/io/trino/tests/product/hive/TestHiveRequireQueryPartitionsFilter.java
Outdated
Show resolved
Hide resolved
okayhooni
force-pushed
the
bugfix/hive_partition_required_schemas
branch
2 times, most recently
from
733ad86 to
405c7c3
Compare
|
2 failing checks(trino-delta-lake & trino-iceberg) are not relevant to this one-line modification on hive connector. :) |
ebyhr
reviewed
Jul 8, 2024
plugin/trino-hive/src/test/java/io/trino/plugin/hive/BaseHiveConnectorTest.java
Outdated
Show resolved
Hide resolved
okayhooni
force-pushed
the
bugfix/hive_partition_required_schemas
branch
2 times, most recently
from
f9769f9 to
b15418f
Compare
ebyhr
changed the title
query-partition-filter-required-schemas config. of hive connectorquery_partition_filter_required_schemas config property in Hive connector
ebyhr
reviewed
Jul 8, 2024
plugin/trino-hive/src/test/java/io/trino/plugin/hive/BaseHiveConnectorTest.java
Outdated
Show resolved
Hide resolved
ebyhr
force-pushed
the
bugfix/hive_partition_required_schemas
branch
2 times, most recently
from
6255eee to
b7a19c0
Compare
ebyhr
force-pushed
the
bugfix/hive_partition_required_schemas
branch
from
b7a19c0 to
739e93a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
query-partition-filter-required-schemasoption to be compatible withquery-partition-filter-requiredAdditional context and related issues
query-partition-filter-required-schemason catalog configuration, and switch on/offquery-partition-filter-requiredoption, depending on source/session by using session property managerquery-partition-filter-required-schemasoption is always applied even thoughquery-partition-filter-required=false.Release notes
(x) This is not user-visible or is docs only, and no release notes are required.