Prevent unwanted product test duplicated runs #20321
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
findepi
added
test
maintenance
findepi
force-pushed
the
findepi/product-test-groups
branch
from
50ff1c2 to
c7b7ed7
Compare
hashhar
reviewed
Jan 10, 2024
testing/trino-product-tests/src/main/java/io/trino/testng/services/VerifyProductTestGroups.java
Outdated
Show resolved
Hide resolved
testing/trino-product-tests/src/main/java/io/trino/testng/services/VerifyProductTestGroups.java
Outdated
Show resolved
Hide resolved
|
will convert it from a test listener to a classpath scanner, so that it can be run locally quickly |
findepi
force-pushed
the
findepi/product-test-groups
branch
3 times, most recently
from
d73a81e to
6cc327a
Compare
losipiuk
reviewed
Jan 11, 2024
testing/trino-product-tests/src/main/java/io/trino/tests/product/sqlserver/TestInsert.java
Show resolved
Hide resolved
losipiuk
approved these changes
Jan 11, 2024
findepi
force-pushed
the
findepi/product-test-groups
branch
2 times, most recently
from
207bbc0 to
c429eda
Compare
|
PTAL |
findepi
force-pushed
the
findepi/product-test-groups
branch
3 times, most recently
from
12f82ce to
dc7515b
Compare
findepi
force-pushed
the
findepi/product-test-groups
branch
from
dc7515b to
276fc34
Compare
|
rebased after the release |
findepi
changed the title
losipiuk
reviewed
Jan 12, 2024
|
|
||
| public class HiveProductTest | ||
| extends ProductTest | ||
| { | ||
| static { | ||
| TestGroups.FakeUsageForMavenDependencyChecker.fakeUse(); |
There was a problem hiding this comment.
class name is "fake usage for maven dependency checker". that's what i would write in a code comment. should i add more context?
losipiuk
reviewed
Jan 12, 2024
| @@ -46,7 +46,7 @@ public final class TestGroups | |||
| public static final String OAUTH2_REFRESH = "oauth2_refresh"; | |||
| public static final String MYSQL = "mysql"; | |||
| public static final String TRINO_JDBC = "trino_jdbc"; | |||
| public static final String QUERY_ENGINE = "qe"; | |||
| public static final String QE = "qe"; // query engine | |||
There was a problem hiding this comment.
can you rename to QUERY_ENGINE as a followup?
There was a problem hiding this comment.
i didn't want to do replacements in convention based tests, because it's more erronous (no static checks).
the convention based need some cleanup and/or pruning (eg #20352)
let's leave it for a follow-up
losipiuk
reviewed
Jan 12, 2024
|
|
||
| assertThat(name).as("Name of %s", field) | ||
| .isUpperCase() | ||
| .matches("[A-Z][_A-Z0-9]+") |
There was a problem hiding this comment.
Why don't you like single char test group names :P
There was a problem hiding this comment.
i didn't mean to prohibit them, sorry!
it was just the easiest way to have some validation.
losipiuk
reviewed
Jan 12, 2024
Comment on lines
147
to
152
| # Run all tests in the functions and create_table groups | ||
| testing/bin/ptl test run \ | ||
| --environment <environment> \ | ||
| [--config <environment config>] \ | ||
| -- -g string_functions,create_tables | ||
| -- -g functions,create_tables | ||
| ``` |
There was a problem hiding this comment.
leftover -- i was trying to cleanup groups in convention based tests, but decided it's better not to do this in this PR. will revert.
losipiuk
approved these changes
Jan 12, 2024
Remove product test groups that are not used for defining test suites.
Verify that a product test has reasonably assigned groups. Incorrectly assigned groups may lead to a test executing too many times, or not executing at all.
Remove product test groups that are not used by any tests. These are meaningless. They do not need to be defined pro actively.
findepi
force-pushed
the
findepi/product-test-groups
branch
from
276fc34 to
c125d09
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Verify that a product test has reasonably assigned groups. Incorrectly assigned groups may lead to a test executing too many times, or not executing at all.
relates to #15096, #20320