-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Some product tests are executed in multiple test suites #15096
Comments
In general, this is very intentional. |
Do you think it's still worth verifying if there are no accidental cases? |
I looked at results and here's my summary. Seems we don't have true duplicates. suite-1 and suite-3 "appear" to have duplicates but they run against different environments (kerberos, tls, non-secured). Other duplicate appearing stuff like Iceberg running as part of suite-7-non-generic is also not true duplicate since it's testing using a catalog configured with redirections. So nothing to be done here other than the learning that numbered suites were probably a bad idea to begin with. Since they make it easy to accidentally have some test run with multiple suites even if not needed. Thanks for verifying this though @nineinchnick. |
If we continue splitting up suites as we did in #14818 it'll be a good opportunity to come up with meaningful names. |
When working on #14818 we got the idea to verify if there are product tests executed in multiple suites. If these suites would be using similar environments, such tests should run only in one of them. This might reduce the total CI workflow run duration and reduce the CI queue.
To identify such tests, we could use the data scraped from the GitHub API in https://github.com/nineinchnick/trino-cicd and the following query:
Example result: 20221118_080731_20056_2wrxi.csv
The text was updated successfully, but these errors were encountered: