Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove TestNG from test classpath #20139

Merged
merged 3 commits into from
Dec 18, 2023
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Migrate trino-record-decoder off TestNG assertions
findepi committed Dec 18, 2023
commit 48a3e065238ac9a0b8bca3e2089099bf737edd5f
6 changes: 0 additions & 6 deletions lib/trino-record-decoder/pom.xml
Original file line number Diff line number Diff line change
@@ -165,12 +165,6 @@
<artifactId>junit-jupiter-engine</artifactId>
<scope>test</scope>
</dependency>

<dependency>
<groupId>org.testng</groupId>
<artifactId>testng</artifactId>
<scope>test</scope>
</dependency>
</dependencies>

<repositories>
Original file line number Diff line number Diff line change
@@ -22,7 +22,7 @@
import java.util.Map;

import static org.assertj.core.api.Assertions.assertThat;
import static org.testng.Assert.assertEquals;
import static org.assertj.core.data.Offset.offset;

public final class DecoderTestUtil
{
@@ -55,7 +55,7 @@ public static void checkValue(Map<DecoderColumnHandle, FieldValueProvider> decod
{
FieldValueProvider provider = decodedRow.get(handle);
assertThat(provider).isNotNull();
assertEquals(provider.getDouble(), value, 0.0001);
assertThat(provider.getDouble()).isCloseTo(value, offset(0.0001));
}

public static void checkValue(Map<DecoderColumnHandle, FieldValueProvider> decodedRow, DecoderColumnHandle handle, boolean value)