Remove TestNG from test classpath #20139
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove TestNG from classpath of modules that do not use it anymore.
findepi
added
the
no-release-notes
wendigo
approved these changes
Dec 15, 2023
martint
reviewed
Dec 15, 2023
findepi
force-pushed
the
findepi/less-dep
branch
from
d872d8f to
c50904a
Compare
losipiuk
reviewed
Dec 18, 2023
|
|
||
| <dependency> | ||
| <groupId>org.testng</groupId> | ||
| <artifactId>testng</artifactId> |
There was a problem hiding this comment.
why wasn't enforcer complaining that we have unused dependency declared?
There was a problem hiding this comment.
i think it doesn't enforce test scope at all
losipiuk
approved these changes
Dec 18, 2023
|
CI #16315 twice |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove TestNG from classpath of modules that do not use it anymore.