Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid Slice allocations in decimal aggregation #18868

Merged
merged 1 commit into from
Aug 31, 2023

Conversation

raunaqmorarka
Copy link
Member

@raunaqmorarka raunaqmorarka commented Aug 30, 2023

Description

Slice allocations in Type#getSlice cause significant CPU overhead on some decimal aggregation queries

Additional context and related issues

Release notes

( ) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
(x) Release notes are required, with the following suggested text:

# General
* Improve performance of decimal aggregations. ({issue}`18868`)

@raunaqmorarka
Copy link
Member Author

@raunaqmorarka raunaqmorarka merged commit d1a5a62 into trinodb:master Aug 31, 2023
@raunaqmorarka raunaqmorarka deleted the agg-slice branch August 31, 2023 02:56
@github-actions github-actions bot added this to the 426 milestone Aug 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants