Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove duplicate isIcebergTable, isDeltaLakeTable methods #18341

Merged
merged 5 commits into from
Jul 20, 2023
Merged

Remove duplicate isIcebergTable, isDeltaLakeTable methods #18341

merged 5 commits into from
Jul 20, 2023

Conversation

findepi
Copy link
Member

@findepi findepi commented Jul 19, 2023

No description provided.

findepi added 3 commits July 19, 2023 13:13
@findepi
Remove duplicate isIcebergTable method
0c368d2 
Hive and Iceberg should agree on what is and what isn't an Iceberg
table, so let them use one common implementation of `isIcebergTable`
method.
@findepi
Simplify HiveUtil.isDeltaLakeTable
b140d26 
Match HiveUtil.isIcebergTable in simplicity
@findepi
Remove duplicate isDeltaLakeTable method
ad29149
@findepi findepi added the no-release-notes This pull request does not require release notes entry label Jul 19, 2023
@cla-bot cla-bot bot added the cla-signed label Jul 19, 2023
@github-actions github-actions bot added tests:hive iceberg Iceberg connector delta-lake Delta Lake connector hive Hive connector labels Jul 19, 2023
@findepi findepi force-pushed the findepi/remove-duplicate-isicebergtable-method-af481b branch from 967e797 to 620e9cb Compare July 20, 2023 08:47
@findepi
Copy link
Member Author

findepi commented Jul 20, 2023

Due to a typo Hive redirects were temporarily broken. This uncovered the fact that some tests, eg TestDeltaLakeTransactionLogCache.testAllDataFilesAreLoadedWhenTransactionLogFileAfterTheCachedTableVersionIsMissing or TestDeltaLakeSystemTableCompatibility work only thanks to redirects because they don't qualify table names with catalog and don't select default catalog.

This will be fixed by #18126 cc @wendigo

@findepi findepi merged commit 7a1df27 into trinodb:master Jul 20, 2023
@findepi findepi deleted the findepi/remove-duplicate-isicebergtable-method-af481b branch July 20, 2023 11:04
@github-actions github-actions bot added this to the 423 milestone Jul 20, 2023
@colebow colebow mentioned this pull request Aug 2, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@findinpath findinpath findinpath approved these changes

@ebyhr ebyhr ebyhr approved these changes

@alexjo2144 alexjo2144 Awaiting requested review from alexjo2144

Assignees
No one assigned
Labels
cla-signed delta-lake Delta Lake connector hive Hive connector iceberg Iceberg connector no-release-notes This pull request does not require release notes entry
Milestone
423
Development

Successfully merging this pull request may close these issues.
3 participants
@findepi @ebyhr @findinpath