Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require product test to select catalog explicitly #18126

Open
findepi opened this issue Jul 4, 2023 · 2 comments
Open

Require product test to select catalog explicitly #18126

findepi opened this issue Jul 4, 2023 · 2 comments

Comments

@findepi
Copy link
Member

findepi commented Jul 4, 2023

in

jdbc_url: jdbc:trino://${databases.presto.host}:${databases.presto.port}/hive/${databases.hive.schema}

we select hive catalog as default for product tests

This made sense in the beginning, when hive was the focus, but now is no longer beneficial and leads to bugs in tests. For example it's very easy to go to hive.default.nation table instead of some other connector's nation table. This is more likely with hive because hive connector is often configured.

relates to 44a8a7c#r1251887980 and similar changes in the past

@findepi
Copy link
Member Author

findepi commented Jul 4, 2023

cc @wendigo

@findepi
Copy link
Member Author

findepi commented Jul 4, 2023

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging a pull request may close this issue.

1 participant