Expose erroneous handling for recursive listing in S3 #18173
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…values Fix query failure when `hive.recursive-directories` is used and the partition directory contains any url-encoded characters, i.e. when partition value contains pretty much anything other than letters/digits.
findinpath
force-pushed
the
findinpath/s3-too-slashed-recursive-listing
branch
from
347ffad to
d01d43f
Compare
|
I don’t think it’s a user problem, since we restored normalization — no double slashes should be there for hive connector. in theory we could still have problem if hive table has double slashes due to external setup (eg declared explicitly in Glue), but we didn’t see this in real life, and currently believe this not to be a real problem (and it never worked correctly anyway) We still can add a regression test, which would prevent us from removing table location normalization without fixing the problem you found. Is it possible to write such a test? Note that a unit test on HiveFileIterator level doesn’t have this property, because it’s independent on whether hive locations are normalized or not. |
findinpath
force-pushed
the
findinpath/s3-too-slashed-recursive-listing
branch
from
d01d43f to
30482e8
Compare
AWS S3 allows having keys containing multiple slashes e.g. : `s3://bucket/schema/table//file` This test cases exposes the fact that the recursive listing in Hive does erroneously handle keys containing multiple slashes.
findinpath
force-pushed
the
findinpath/s3-too-slashed-recursive-listing
branch
from
30482e8 to
ed45c4d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
AWS S3 allows having keys containing multiple slashes
e.g. :
s3://bucket/schema/table//fileThis test cases exposes the fact that the recursive listing in
Hive does erroneously handle keys containing multiple slashes.
Contains cherry-pick from #18167
Additional context and related issues
Release notes
( ) This is not user-visible or docs only and no release notes are required.
( ) Release notes are required, please propose a release note for me.
( ) Release notes are required, with the following suggested text: