Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix recursive listing from Hive partitions containing non-alphabetic values #18167

Merged
merged 2 commits into from
Jul 10, 2023
Merged

Fix recursive listing from Hive partitions containing non-alphabetic values #18167

merged 2 commits into from
Jul 10, 2023

Conversation

findepi
Copy link
Member

@findepi findepi commented Jul 7, 2023

Fix query failure when hive.recursive-directories is used and the partition directory contains any url-encoded characters, i.e. when partition value contains pretty much anything other than letters/digits.

Fixes #18149

@cla-bot cla-bot bot added the cla-signed label Jul 7, 2023
@findepi findepi mentioned this pull request Jul 7, 2023
Closed
@findepi
Fix recursive listing from Hive partitions containing non-alphabetic …
c710b41 
…values

Fix query failure when `hive.recursive-directories` is used and the
partition directory contains any url-encoded characters, i.e. when
partition value contains pretty much anything other than letters/digits.
@findepi findepi force-pushed the findepi/fix-recursive-listing-from-hive-partitions-containing-non-alphabetic-values-200fe8 branch from 79e7b5c to c710b41 Compare July 7, 2023 09:53
@findepi findepi requested a review from findinpath July 7, 2023 09:53
@github-actions github-actions bot added tests:hive hive Hive connector labels Jul 7, 2023
guyco33
guyco33 approved these changes Jul 7, 2023
View reviewed changes
Copy link
Member

@guyco33 guyco33 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed URL decode is not correct here as it replaces the + sign to space character.
Using Location instead of constructing value from Path is safer.

This was referenced Jul 7, 2023
Merged
Closed
@electrum
Copy link
Member

electrum commented Jul 7, 2023

Commit title is too long

@findepi findepi merged commit cbbf383 into master Jul 10, 2023
@findepi findepi deleted the findepi/fix-recursive-listing-from-hive-partitions-containing-non-alphabetic-values-200fe8 branch July 10, 2023 05:38
@github-actions github-actions bot added this to the 422 milestone Jul 10, 2023
@colebow colebow mentioned this pull request Jul 12, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@findinpath findinpath findinpath approved these changes

@guyco33 guyco33 guyco33 approved these changes

@losipiuk losipiuk losipiuk approved these changes

@electrum electrum Awaiting requested review from electrum

@wendigo wendigo Awaiting requested review from wendigo

@ebyhr ebyhr Awaiting requested review from ebyhr

@alexjo2144 alexjo2144 Awaiting requested review from alexjo2144

@kokosing kokosing Awaiting requested review from kokosing

Assignees
No one assigned
Labels
cla-signed hive Hive connector
Milestone
422
Development

Successfully merging this pull request may close these issues.

Failure when Hive partition value contains + and hive.recursive-directories is enabled
5 participants
@findepi @electrum @losipiuk @guyco33 @findinpath