Ensure statistics predicate only for base column in delta connector #17449
+2
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
findepi
requested review from
ebyhr and
alexjo2144
and removed request for
findepi
We didn't create statistics predicate for complex types even without this change because |
findinpath
approved these changes
May 15, 2023
|
Undoing my approval to wait until the comment #17449 (comment) gets clarified. |
tableHandle.getNonPartitionConstraint() can include the dereferenced field if dereference field is used as a predicate. Since stats for dereferenced field is not supported, so filter those fields before creating statistics predicate.
krvikash
force-pushed
the
trino-17085-follow-up
branch
from
8f8b5e0 to
49fede7
Compare
krvikash
changed the title
|
Thanks, @ebyhr | @findinpath for the review. I have updated the commit message and put the description in the commit body. |
ebyhr
approved these changes
May 15, 2023
|
Does this need release notes? cc @ebyhr |
krvikash
added
the
no-release-notes
|
No, It does not require release notes. As we didn't create statistics predicate for complex types. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up of #17085 (comment)