Allow disabling caching missing tables in CachingMetastore #17177
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
findepi
added
the
no-release-notes
findepi
requested review from
electrum,
homar,
losipiuk,
sopel39,
ebyhr,
alexjo2144 and
kokosing
findepi
force-pushed
the
findepi/allow-disabling-caching-missing-tables-in-cachingmetastore-6c57b6
branch
from
72a207d to
0101fee
Compare
ebyhr
approved these changes
Apr 24, 2023
plugin/trino-hive/src/main/java/io/trino/plugin/hive/metastore/cache/CachingHiveMetastore.java
Outdated
Show resolved
Hide resolved
| return value; | ||
| } | ||
| cache.invalidate(key); | ||
| } | ||
| return cache.getUnchecked(key); |
There was a problem hiding this comment.
Is it necessary call this method if the value is not present?
There was a problem hiding this comment.
yes, cache.getIfPresent didn't load anything yet
sopel39
reviewed
Apr 24, 2023
| @@ -141,6 +141,7 @@ public void setUp() | |||
| .cacheTtl(new Duration(5, TimeUnit.MINUTES)) | |||
| @@ -943,7 +982,7 @@ public Optional<List<String>> getPartitionNamesByFilter( | |||
| List<String> columnNames, | |||
| TupleDomain<String> partitionKeysFilter) | |||
| { | |||
| return get(partitionFilterCache, partitionFilter(databaseName, tableName, columnNames, partitionKeysFilter)); | |||
| return getOptional(partitionFilterCache, partitionFilter(databaseName, tableName, columnNames, partitionKeysFilter)); | |||
There was a problem hiding this comment.
shouldn't it be also used in bulk loaded cache?
There was a problem hiding this comment.
perhaps, but I didn't find the bulk loaded cache which caches absence, can you help me with that?
Make it clear that `TestCachingHiveMetastore`'s `metastore` and `statsCacheMetastore` differ with `metadataCacheEnabled` and `statsCacheEnabled` -- make it apparent by the later's name and in their initialization.
Table absence is harder to less interesting to cache and sometimes undesirable at all. This is similar to `metadata.cache-missing` config we have for JDBC connectors.
Enforce the caller provides configuration, so that `CachingHiveMetastoreConfig` is the only source of default configuration.
findepi
force-pushed
the
findepi/allow-disabling-caching-missing-tables-in-cachingmetastore-6c57b6
branch
from
0101fee to
60776c0
Compare
findepi
deleted the
findepi/allow-disabling-caching-missing-tables-in-cachingmetastore-6c57b6
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Table absence is harder to less interesting to cache and sometimes undesirable at all. This is similar to
metadata.cache-missingconfig we have for JDBC connectors.