Remove default configuration in Caching metastore builder

Enforce the caller provides configuration, so that `CachingHiveMetastoreConfig` is the only source of default configuration.
trinodb · Apr 25, 2023 · f18f0d4 · f18f0d4
1 parent 2a3f53a
commit f18f0d4
Showing 1 changed file with 4 additions and 2 deletions.
diff --git a/...n/trino-hive/src/main/java/io/trino/plugin/hive/metastore/cache/CachingHiveMetastore.java b/...n/trino-hive/src/main/java/io/trino/plugin/hive/metastore/cache/CachingHiveMetastore.java
@@ -161,6 +161,7 @@ public static CachingHiveMetastore memoizeMetastore(HiveMetastore delegate, long
                 .maximumSize(maximumSize)
                 .statsRecording(StatsRecording.DISABLED)
                 .cacheMissing(true)
+                .partitionCacheEnabled(true)
                 .build();
     }
 
@@ -177,7 +178,7 @@ public static class CachingHiveMetastoreBuilder
         private Long maximumSize;
         private StatsRecording statsRecording = StatsRecording.ENABLED;
         private Boolean cacheMissing;
-        private boolean partitionCacheEnabled = true;
+        private Boolean partitionCacheEnabled;
 
         public CachingHiveMetastoreBuilder() {}
 
@@ -192,7 +193,7 @@ private CachingHiveMetastoreBuilder(
                 Long maximumSize,
                 StatsRecording statsRecording,
                 Boolean cacheMissing,
-                boolean partitionCacheEnabled)
+                Boolean partitionCacheEnabled)
         {
             this.delegate = delegate;
             this.executor = executor;
@@ -300,6 +301,7 @@ public CachingHiveMetastore build()
             requireNonNull(delegate, "delegate not set");
             requireNonNull(maximumSize, "maximumSize not set");
             requireNonNull(cacheMissing, "cacheMissing not set");
+            requireNonNull(partitionCacheEnabled, "partitionCacheEnabled not set");
             return new CachingHiveMetastore(
                     delegate,
                     metadataCacheEnabled,