Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation copy and style edits Delta Lake #16920

Merged
merged 1 commit into from
Apr 26, 2023

Conversation

tlblessing
Copy link
Member

@tlblessing tlblessing commented Apr 6, 2023

Description

Edits to make corrections for:

  • Improper grammar
  • Typos
  • Improper capitalization
  • Incorrect punctuation, such as comma usage
  • Add adjectives to make subjects clear
  • Formatting for default values
  • Line wrapping to 80 char where possible per conventions

Noticed these last year while working on fixing the description of the delta.domain-compaction-threshold export config property.

Additional context and related issues

Release notes

(x) This is not user-visible or docs only and no release notes are required.
( ) Release notes are required, please propose a release note for me.
( ) Release notes are required, with the following suggested text:

@cla-bot cla-bot bot added the cla-signed label Apr 6, 2023
@tlblessing tlblessing marked this pull request as ready for review April 7, 2023 16:14
Copy link
Member

@mosabua mosabua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good improvements. Just needs a few small updates and then ready to go.

docs/src/main/sphinx/connector/delta-lake.rst Outdated Show resolved Hide resolved
docs/src/main/sphinx/connector/delta-lake.rst Outdated Show resolved Hide resolved
docs/src/main/sphinx/connector/delta-lake.rst Outdated Show resolved Hide resolved
docs/src/main/sphinx/connector/delta-lake.rst Show resolved Hide resolved
@tlblessing tlblessing requested a review from mosabua April 17, 2023 19:32
@tlblessing tlblessing force-pushed the tb/doc-3665 branch 2 times, most recently from c84bc86 to 944379b Compare April 17, 2023 21:09
Copy link
Member

@mosabua mosabua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of more edits needed. Also please change the commit message to

Improve style of Delta Lake connector documentation

docs/src/main/sphinx/connector/delta-lake.rst Outdated Show resolved Hide resolved
docs/src/main/sphinx/connector/delta-lake.rst Outdated Show resolved Hide resolved
docs/src/main/sphinx/connector/delta-lake.rst Outdated Show resolved Hide resolved
docs/src/main/sphinx/connector/delta-lake.rst Show resolved Hide resolved
docs/src/main/sphinx/connector/delta-lake.rst Show resolved Hide resolved
@tlblessing tlblessing requested a review from mosabua April 26, 2023 21:29
@mosabua mosabua merged commit 051c7b9 into trinodb:master Apr 26, 2023
@github-actions github-actions bot added this to the 415 milestone Apr 26, 2023
ssheikin pushed a commit to ssheikin/trino that referenced this pull request May 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

2 participants