Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correct the description of the delta.domain-compaction-threshold export config property #13039

Merged
merged 2 commits into from
Jul 1, 2022
Merged

Correct the description of the delta.domain-compaction-threshold export config property #13039

merged 2 commits into from
Jul 1, 2022

Conversation

tlblessing
Copy link
Member

@tlblessing tlblessing commented Jun 29, 2022 •
edited
Loading

Description

Is this change a fix, improvement, new feature, refactoring, or other?

Fix description of the delta.domain-compaction-threshold export config property. Splitting out minor improvements from the description correction per Manfred. See closed PR #12965 for review feedback conversations.

Is this a change to the core query engine, a connector, client library, or the SPI interfaces? (be specific)

connector

How would you describe this change to a non-technical end user or system administrator?

The description for an expert level setting was incorrect. Revised per feedback from SMEs.

Related issues, pull requests, and links

See closed PR #12965 for review feedback conversations.

Documentation

( ) No documentation is needed.
(x) Sufficient documentation is included in this PR.
( ) Documentation PR is available with #prnumber.
( ) Documentation issue #issuenumber is filed, and can be handled later.

@cla-bot cla-bot bot added the cla-signed label Jun 29, 2022
@github-actions github-actions bot added the docs label Jun 29, 2022
@tlblessing tlblessing mentioned this pull request Jun 29, 2022
Closed
mosabua
mosabua approved these changes Jun 29, 2022
View reviewed changes
Copy link
Member

@mosabua mosabua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is vague enough without being meaningless or too detailed about implementation. And its no longer wrong ;-)

hashhar
hashhar approved these changes Jun 30, 2022
View reviewed changes
Copy link
Member

@hashhar hashhar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM % comment

@tlblessing
Copy link
Member Author

LGTM % comment

Thanks @hashhar, committed your suggestion.

@hashhar hashhar merged commit 4e78e4e into trinodb:master Jul 1, 2022
@github-actions github-actions bot added this to the 389 milestone Jul 1, 2022
@colebow colebow mentioned this pull request Jul 5, 2022
Merged
@tlblessing tlblessing mentioned this pull request Apr 6, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hashhar hashhar hashhar approved these changes

@mosabua mosabua mosabua approved these changes

@colebow colebow Awaiting requested review from colebow

@findepi findepi Awaiting requested review from findepi

Assignees
No one assigned
Labels
cla-signed docs
Milestone
389
Development

Successfully merging this pull request may close these issues.
3 participants
@tlblessing @mosabua @hashhar