Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust GC related settings for tests #15632

Merged
merged 1 commit into from
Jan 9, 2023
Merged

Adjust GC related settings for tests #15632

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,6 +92,10 @@
Force bigger region size in attempt to help G1 utilize heap fully. -->
<air.test.jvm.additional-arguments>
-XX:G1HeapRegionSize=32M
-XX:+UnlockDiagnosticVMOptions
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is it required to set XX:GCLockerRetryAllocationCount ?

Copy link
Contributor Author

@arhimondr arhimondr Jan 6, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's actually needed for both 😃

<!-- bump from default of 2 -->
-XX:GCLockerRetryAllocationCount=10
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

only 10?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's 2 by default, I think 10 should be sufficient. Do you think it should be higher?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh, thought default is about 10. fine.
maybe add <!-- bump from default of 2 --> ?

-XX:-G1UsePreventiveGC
</air.test.jvm.additional-arguments>

<air.javadoc.lint>-missing</air.javadoc.lint>
Expand Down